CLN: memory_map do not silently fail #44777
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
twoertwein
commented
Dec 6, 2021
twoertwein
commented
- closes #xxxx
- tests added / passed
- Ensure all linting tests pass, see here for how to run them
- whatsnew entry
twoertwein
commented
Dec 6, 2021
| ) | ||
| # error: "BaseBuffer" has no attribute "close" | ||
| handle.close() # type: ignore[attr-defined] | ||
| handles.remove(handle) |
There was a problem hiding this comment.
If a user opened a file, this would cause an error (it is not in handles).
twoertwein
commented
Dec 6, 2021
| @@ -699,15 +699,15 @@ def test_encoding_mmap(memory_map): | |||
| GH 23254. | |||
| """ | |||
| encoding = "iso8859_1" | |||
| data = BytesIO(" 1 A Ä 2\n".encode(encoding)) | |||
| df = read_fwf( | |||
| data, | |||
There was a problem hiding this comment.
This never tested memory_map since it silently failed.
|
thanks @twoertwein |
4 tasks
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.